Fix the deprecation status of the datetime library usage #157
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: olamidepeterojo <[email protected]>
|
@olamidepeterojo Thanks for the pull request. Could you please fix the tests associated with this pull request while you are it? |
gridhead
requested changes
Jan 20, 2025
There was a problem hiding this comment.
@olamidepeterojo Thanks for the pull request. Could you please fix the tests associated with this pull request while you are it?
gridhead
requested changes
Jan 21, 2025
There was a problem hiding this comment.
This pull request is incomplete.
The deprecation status has not been lifted from the following sections.
dateinfo=datetime.utcfromtimestamp(standard.timedata).strftime("%c"),
mo=datetime.utcfromtimestamp(standard.timedata).strftime("%b").lower(),
dd=datetime.utcfromtimestamp(standard.timedata).strftime("%d"),
yy=datetime.utcfromtimestamp(standard.timedata).strftime("%Y"),
hh=datetime.utcfromtimestamp(standard.timedata).strftime("%H"),
mm=datetime.utcfromtimestamp(standard.timedata).strftime("%M"), "comment": f"This test comment with broken links was created on {datetime.utcfromtimestamp(int(time())).strftime('%c')}.", # noqa: E501Amend the existing commit to include the suggested changes and let me know once this pull request is ready for another round of reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #151